Bug 2764 – WifiSpectrumModelId doesn't distinguish 11ax from legacy

Bug 2764 - WifiSpectrumModelId doesn't distinguish 11ax from legacy


Summary:	WifiSpectrumModelId doesn't distinguish 11ax from legacy

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3.27
Hardware:	All All

Importance:	P3 normal
Assigned To:	Rediet

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-07-07 09:15 UTC by Rediet
Modified:	2017-11-02 17:18 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (diff with 12951:51a7df2fd8a2) (2.38 KB, patch) 2017-07-07 09:15 UTC, Rediet	Details \| Diff
Modified wifi-spectrum-example (18.62 KB, text/x-csrc) 2017-07-07 09:17 UTC, Rediet	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rediet 2017-07-07 09:15:48 UTC

Created attachment 2886 [details]
Patch (diff with 12951:51a7df2fd8a2)

WifiSpectrumValueHelper currently considers that 11ax 20 MHz uses the same SpectrumModel as legacy 20 MHz. However, the difference in inter-tone spacing makes the code to crash upon verification of number of bands for OFDM frames (namely Beacon) because 11ax SpectrumModel has been generated beforehand.

The attached patch proposes to solve this point by adding bandBandwith to WifiSpectrumModelId.

Non-reg tests OK.

Comment 1 Rediet 2017-07-07 09:17:25 UTC

Created attachment 2887 [details]
Modified wifi-spectrum-example

Highlights current crash.

Comment 2 Tom Henderson 2017-07-13 01:32:27 UTC

Looks reasonable to me; moving to LAST CALL

Comment 3 sebastien.deronne 2017-07-17 04:03:02 UTC

OK for me as well

Comment 4 Tom Henderson 2017-11-02 13:50:20 UTC

verified and pushed in changeset 13134:59ce6b1e73c3