Bug 2775 – UdpClient packet size attribute is too restrictive

Bug 2775 - UdpClient packet size attribute is too restrictive


Summary:	UdpClient packet size attribute is too restrictive

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	applications
Version:	unspecified
Hardware:	All All

Importance:	P3 normal
Assigned To:	George Riley

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-08-16 18:54 UTC by Tom Henderson
Modified:	2018-05-30 00:16 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2017-08-16 18:54:34 UTC

Comment 1 Tom Henderson 2017-08-16 18:56:16 UTC

The attribute UdpClient::PacketSize limits to 1500 bytes, which is too limiting (MTUs may be larger, or fragmentation may be tolerated).  I propose to raise the limit to the value of 65507 bytes.

diff -r f010860857bd src/applications/model/udp-client.cc
--- a/src/applications/model/udp-client.cc	Wed Aug 16 19:13:57 2017 +0300
+++ b/src/applications/model/udp-client.cc	Wed Aug 16 15:53:04 2017 -0700
@@ -68,7 +68,7 @@
                    "Size of packets generated. The minimum packet size is 12 bytes which is the size of the header carrying the sequence number and the time stamp.",
                    UintegerValue (1024),
                    MakeUintegerAccessor (&UdpClient::m_size),
-                   MakeUintegerChecker<uint32_t> (12,1500))
+                   MakeUintegerChecker<uint32_t> (12,65507))
   ;
   return tid;
 }

Comment 2 Tommaso Pecorella 2017-08-20 12:06:31 UTC

+1

Comment 3 Tom Henderson 2018-05-30 00:16:25 UTC

pushed in changeset 13606:585dab8f400f