Bug 279 – Packets need metadata support for printing without header checking

Bug 279 - Packets need metadata support for printing without header checking


Summary:	Packets need metadata support for printing without header checking

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	core
Version:	pre-release
Hardware:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-08-09 13:58 UTC by Mathieu Lacage
Modified:	2008-08-25 18:13 UTC (History)
CC List:	0 users

See Also:

Attachments
add EnableChecking and EnablePrinting (7.57 KB, patch) 2008-08-11 13:17 UTC, Mathieu Lacage	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Lacage 2008-08-09 13:58:24 UTC

there are lots of cases where we want to enable the packet metadata to be able to print the content of the packet but where we don't want to enable the packet error checking. 

We could add the following functions:

class Packet
{
public:
  static void EnableChecking (void);
  static void DisableChecking (void);
};

the default would be no checking to be consistent with the "no metadata" default.

Comment 1 Tom Henderson 2008-08-10 13:26:01 UTC

+1

Comment 2 Craig Dowell 2008-08-10 14:33:37 UTC

+1

Comment 3 Mathieu Lacage 2008-08-11 13:17:18 UTC

Created attachment 227 [details]
add EnableChecking and EnablePrinting

Comment 4 Mathieu Lacage 2008-08-11 13:18:19 UTC

Packet::EnableMetadata is made deprecated. Packet::EnablePrinting allows you to call Packet::Print successfully. Packet::EnableChecking enables error checking.

please, review.

Comment 5 Tom Henderson 2008-08-25 13:04:04 UTC

(In reply to comment #4)
> Packet::EnableMetadata is made deprecated. Packet::EnablePrinting allows you to
> call Packet::Print successfully. Packet::EnableChecking enables error checking.
> 
> please, review.
> 

I reviewed this patch and it looks good to me.

Comment 6 Mathieu Lacage 2008-08-25 18:13:56 UTC

changeset: 065488d0420c