Bug 2798 – LTE tests fail if default DL and/or UL bandwidth is changed in LteEnbNetDevice

Bug 2798 - LTE tests fail if default DL and/or UL bandwidth is changed in LteEnbNetDevice


Summary:	LTE tests fail if default DL and/or UL bandwidth is changed in LteEnbNetDevice

Status:	RESOLVED WONTFIX

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 minor
Assigned To:	Biljana Bojović

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-10-08 03:20 UTC by Michele Polese
Modified:	2018-06-05 12:29 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Proposed patch (18.28 KB, patch) 2017-10-08 03:20 UTC, Michele Polese	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michele Polese 2017-10-08 03:20:56 UTC

Created attachment 2932 [details]
Proposed patch

Dear all,
the tests that are patched in the attached file fail when the default DL and/or UL bandwidth is updated in the attributes of LteEnbNetDevice (DlBandwidth and UlBandwidth attributes). Some of the tests use 25 RBs to compute the noise power in the SINR, while other assume 25 RBs to perform scheduling and so on. 
An ns-3 user would probably not change the default value directly in the LteEnbNetDevice class, nonetheless I think that it is important to account for this possibility in the tests. 
In the proposed patch I set the LteEnbNetDevice DL or UL bandwidth to 25 RBs when needed.
Best,
Michele

Comment 1 Manuel Requena 2018-06-05 12:29:56 UTC

Hi Michele,

I see your point that some tests depend on some default values but it is counterintuitive to me to set any parameter in the tests/examples with the same value as the default values of the LteEnbNetDevice.

I would set any parameter in the tests/examples only if it changes from its default value.

Best regards,
Manuel