Bugzilla – Bug 282
Ipv4L4Demux is useful ?
Last modified: 2008-09-02 20:23:36 UTC
I can't figure out why this code has not been merged in the Ipv4L3Protocol class and the Insert method made a public method of Ipv4L3Protocol. Is there someone who knows this ?
Created attachment 236 [details] move Ipv4L4Demux functionality to Ipv4L3Protocol.
I am okay with this patch. I think we need to solicit some feedback from George, but I can't seem to add George as a CC...
this is because george has no bugzilla account
(In reply to comment #2) > I am okay with this patch. I think we need to solicit some feedback from > George, but I can't seem to add George as a CC... > George has an account now, but that was another bug :-) After speaking with him, the utility of it was simply logical separation between layer three, and the interface between layer three and layer four. That said, he doesn't feel strongly enough about this to prevent what you suggest. There are lots of "changes" (which look like they aren't really changes) to the python bindings in this diff...I guess this is a result of running the pybindgen scanner for the updated API? So long as this is the case, please feel free to apply.
(In reply to comment #4) > (In reply to comment #2) > > I am okay with this patch. I think we need to solicit some feedback from > > George, but I can't seem to add George as a CC... > > > > George has an account now, but that was another bug :-) > > After speaking with him, the utility of it was simply logical separation > between layer three, and the interface between layer three and layer four. > That said, he doesn't feel strongly enough about this to prevent what you > suggest. > > There are lots of "changes" (which look like they aren't really changes) to the > python bindings in this diff...I guess this is a result of running the > pybindgen scanner for the updated API? So long as this is the case, please > feel free to apply. yes, this is the result of running the scanner. >
changeset ad0a36bfdb62