Bug 2850 – external modules defining `min_version` lead to bake crashing when using Python 3

Bug 2850 - external modules defining `min_version` lead to bake crashing when using Python 3


Summary:	external modules defining `min_version` lead to bake crashing when using Pyth...

Status:	RESOLVED FIXED

Product:	bake
Classification:	Unclassified
Component:	bake
Version:	unspecified
Hardware:	All All

Importance:	P3 normal
Assigned To:	Daniel Camara

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-01-12 04:49 UTC by Mathias Ettinger
Modified:	2018-03-05 23:55 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Patch that solved the issue (751 bytes, patch) 2018-01-12 04:49 UTC, Mathias Ettinger	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathias Ettinger 2018-01-12 04:49:36 UTC

Created attachment 2999 [details]
Patch that solved the issue

When using an external XML file in the `contrib` folder of Bake, if this file defines a module using `min_version` (e.g. min_version="ns-3.26") then running configure lead to an error:

    $ python3 bake.py configure -e ns-3.27 -e sns3-satellite

    '<=' not supported between instances of 'str' and 'NoneType'

Please find attached a patch that resolved this issue for me and let me install and build both NS-3 and the SNS-3 external module.

Comment 1 Tom Henderson 2018-01-12 14:24:01 UTC

+1; moving to last call

Comment 2 Tom Henderson 2018-03-05 23:55:14 UTC

fixed in changeset 394:6dfa00ee748f