Bug 2851 - Bake don't use the current interpretter when building
Bake don't use the current interpretter when building
Status: RESOLVED FIXED
Product: bake
Classification: Unclassified
Component: bake
unspecified
All All
: P3 normal
Assigned To: Daniel Camara
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-01-12 05:00 UTC by Mathias Ettinger
Modified: 2018-03-05 23:42 UTC (History)
2 users (show)

See Also:


Attachments
Patch that solved the issue (5.63 KB, patch)
2018-01-12 05:00 UTC, Mathias Ettinger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Ettinger 2018-01-12 05:00:03 UTC
Created attachment 3000 [details]
Patch that solved the issue

Bake make the strong assumption that `python` is the binary used to launch it. This is usually the case but restrict usages such as

    $ python2 bake.py deploy

where /usr/bin/python is a simlink to the Python 3 interpretter. Thus not propagating my choice of using Python 2 to the waf calls when building NS-3.

Instead, builders such as WafModuleBuild or PythonModuleBuild should use `sys.executable` to reflect the choice of the user rather than arbitrarily forcing it.

Please find attached a patch applying such changes.
Comment 1 Tom Henderson 2018-01-12 14:22:28 UTC
+1, moving to last call
Comment 2 Tom Henderson 2018-03-05 23:41:56 UTC
Fixed in changeset 395:c0a5ec615276
Comment 3 Tom Henderson 2018-03-05 23:42:15 UTC
Fixed in changeset 394:6dfa00ee748f