Bug 2871 – uint128_t type not portable

Bug 2871 - uint128_t type not portable


Summary:	uint128_t type not portable

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	internet
Version:	unspecified
Hardware:	All All

Importance:	P3 normal
Assigned To:	Tommaso Pecorella

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-02-08 11:29 UTC by Tom Henderson
Modified:	2018-02-08 20:04 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2018-02-08 11:29:51 UTC

changeset 13277 introduces use of uint128_t type to ipv6-address-helper.cc, but Robert reports that this type is not supported in Visual Studio.

One possibility is to rework the code to use struct in6_addr, or other refactoring...

Comment 1 Tommaso Pecorella 2018-02-08 11:53:00 UTC

Not a big issue. I can use two uint64_t there.

However... what should we do with all the other places where uint128_t is used ?
Should we deprecate it ?

T.

Comment 2 Tom Henderson 2018-02-08 12:15:27 UTC

(In reply to Tommaso Pecorella from comment #1)
> Not a big issue. I can use two uint64_t there.
> 
> However... what should we do with all the other places where uint128_t is
> used ?
> Should we deprecate it ?
> 
> T.

My scan of the codebase is that it is only used in the int64x64 code in core, but multiple implementations with a fallback if uint128_t is not available on the platform.  So I think we need to just fix it in the newly committed code.

Comment 3 Tommaso Pecorella 2018-02-08 20:04:20 UTC

fixed in changeset:   13281:fcb5d90f5a27