Bug 2876 – Do not shrink advWin when we already sent the FIN

Bug 2876 - Do not shrink advWin when we already sent the FIN


Summary:	Do not shrink advWin when we already sent the FIN

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	tcp
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 normal
Assigned To:	natale.patriciello

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-02-16 10:31 UTC by natale.patriciello
Modified:	2018-02-25 05:41 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Fixing the bug (1.64 KB, patch) 2018-02-16 10:31 UTC, natale.patriciello	Details \| Diff
Fix the bug + regression test (5.37 KB, patch) 2018-02-16 10:49 UTC, natale.patriciello	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description natale.patriciello 2018-02-16 10:31:30 UTC

Created attachment 3043 [details]
Fixing the bug

The current code check is in AdvertisedWindowSize is based on IsFinished() from TcpRxBuffer. It assumes that if we get the FIN, then IsFinished() returns true. However, the method checks also for any pending data; in case we send a FIN, then we have a retx timeout, we advertise a shrinked window.

Comment 1 natale.patriciello 2018-02-16 10:49:23 UTC

Created attachment 3044 [details]
Fix the bug + regression test

This patch contains also the regression test

Comment 2 natale.patriciello 2018-02-25 05:41:27 UTC

Fixed in 13328:ed34bc65af73