Bug 2896 – Wrong guard band for transmissions using legacy DSSS

Bug 2896 - Wrong guard band for transmissions using legacy DSSS


Summary:	Wrong guard band for transmissions using legacy DSSS

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 major
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-03-07 10:22 UTC by Rediet
Modified:	2018-03-08 15:39 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Handle use of legacy DSSS transmission (535 bytes, patch) 2018-03-07 10:22 UTC, Rediet	Details \| Diff
other solution (2.07 KB, patch) 2018-03-07 16:28 UTC, sebastien.deronne	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rediet 2018-03-07 10:22:43 UTC

Created attachment 3082 [details]
Handle use of legacy DSSS transmission

Another patch concerning spectrum mask for OFDM updates. I hadn't re-run shell script after merging with latest commits: since channel width is forced to 22 MHz for DSSS (namely for beacons and management frames), GetGuardBand didn't provide correct value for 11n/ax operating in 2.4 GHz band. Code crashes.
The correction is attached.

Comment 1 sebastien.deronne 2018-03-07 13:42:33 UTC

OK with the patch, but then I guess this case is not really needed:

    case WIFI_PHY_STANDARD_80211b:
      guardBandwidth = 10;
      break;

Comment 2 sebastien.deronne 2018-03-07 16:28:52 UTC

Created attachment 3084 [details]
other solution

Rediet, could you please try this patch?
This seems cleaner this way.

Comment 3 Rediet 2018-03-08 14:17:06 UTC

(In reply to sebastien.deronne from comment #2)
> Created attachment 3084 [details]
> other solution
> 
> Rediet, could you please try this patch?
> This seems cleaner this way.

OK for me. Much better this way.

Comment 4 sebastien.deronne 2018-03-08 15:39:32 UTC

Fixed in changeset 13404:43baae45f1b5