Bug 2931 – Queue Disc drops the CE marked packets

Bug 2931 - Queue Disc drops the CE marked packets


Summary:	Queue Disc drops the CE marked packets

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	internet
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 normal
Assigned To:	Tommaso Pecorella

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-06-19 01:43 UTC by Vivek Jain
Modified:	2018-06-19 17:46 UTC (History)
CC List:	4 users (show)

See Also:

Attachments
Modified Mark method to return true when a packet has CE. (1.12 KB, patch) 2018-06-19 01:43 UTC, Vivek Jain	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vivek Jain 2018-06-19 01:43:18 UTC

Created attachment 3114 [details]
Modified Mark method to return true when a packet has CE.

Mark () method currently returns false for a packet that is already marked. This means that a queue disc would drop a marked packet (since it is not able to mark it).

The attached patch resolves this issue.

Mark () method has been modified to return true when a packet is already marked.

Comment 1 Stefano Avallone 2018-06-19 16:57:18 UTC

After looking at what Linux does:

https://elixir.bootlin.com/linux/latest/source/include/net/inet_ecn.h#L75

I agree with the proposed patch.

Do you want me to push this patch on your behalf?

Thanks.

Comment 2 Tom Henderson 2018-06-19 17:15:04 UTC

(In reply to Stefano Avallone from comment #1)
> After looking at what Linux does:
> 
> https://elixir.bootlin.com/linux/latest/source/include/net/inet_ecn.h#L75
> 
> I agree with the proposed patch.
> 
> Do you want me to push this patch on your behalf?

I agree to push this now; you can find Vivek's authorstring in the mercurial log.

Comment 3 Stefano Avallone 2018-06-19 17:46:25 UTC

Pushed with changeset 13657:23cfc99011a6, thanks.