Bug 2940 – convert ns3::QueueDisc::SojournTime trace source to TracedCallback

Bug 2940 - convert ns3::QueueDisc::SojournTime trace source to TracedCallback


Summary:	convert ns3::QueueDisc::SojournTime trace source to TracedCallback

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	traffic-control
Version:	ns-3.28
Hardware:	All All

Importance:	P3 normal
Assigned To:	Stefano Avallone

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-07-03 19:54 UTC by Tom Henderson
Modified:	2018-07-14 10:58 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch to fix (3.17 KB, patch) 2018-07-03 20:00 UTC, Tom Henderson	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2018-07-03 19:54:51 UTC

The current trace source for sojourn time is a traced value, which only reports changes to the sojourn time (i.e. it suppresses writing a trace if the new sojourn time is the same as the old).  It therefore misses dequeue events.  The fix is to convert it from a TracedValue to a TracedCallback.

Comment 1 Tom Henderson 2018-07-03 20:00:42 UTC

Created attachment 3121 [details]
patch to fix

Comment 2 Stefano Avallone 2018-07-04 03:56:47 UTC

Agreed. Feel free to push, thanks.

Comment 3 Tom Henderson 2018-07-14 10:58:30 UTC

fixed in 13688:adf4f2b2462d