Bug 2964 – IdealWifiManager keeps using the same MCS when all transmissions fail

Bug 2964 - IdealWifiManager keeps using the same MCS when all transmissions fail


Summary:	IdealWifiManager keeps using the same MCS when all transmissions fail

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 normal
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-07-27 05:58 UTC by Alexander Krotov
Modified:	2018-08-06 11:49 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Proposed patch (1.26 KB, patch) 2018-07-27 05:58 UTC, Alexander Krotov	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Krotov 2018-07-27 05:58:29 UTC

Created attachment 3153 [details]
Proposed patch

When all transmissions of IdealWifiManager fail, for example
because the channel has degraded since last SNR estimation,
it keeps using the same MCS.

This patch makes it reset SNR to 0.0, so it starts using lowest MCS,
successfully transmits, and receives new correct estimation.

I changed ::DoReportFinalRtsFailed and ::DoReportFinalDataFailed.

Note that there is no need to change ::DoReportAmpduTxStatus, because it means Block ACK has been successfully received.

Comment 1 sebastien.deronne 2018-07-29 08:46:17 UTC

It looks ok for me.
If also fine for Tom who has better knowledge about ideal wifi manager, it can be pushed.

Comment 2 Alexander Krotov 2018-08-06 11:49:18 UTC

Pushed in changeset https://code.nsnam.org/index.cgi/ns-3-dev/rev/b5d73628dc6e

> If also fine for Tom who has better knowledge about ideal wifi manager, it can be pushed.

There are no objections for a week so I assume it is ok. If it causes any problems it is easier to revert.