Bug 2974 – Inconsistent declaration of IPV6 methods

Bug 2974 - Inconsistent declaration of IPV6 methods


Summary:	Inconsistent declaration of IPV6 methods

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 normal
Assigned To:	Biljana Bojović

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-08-21 08:29 UTC by Zoraze Ali
Modified:	2018-08-26 09:51 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Patch (2.43 KB, patch) 2018-08-21 08:32 UTC, Zoraze Ali	Details \| Diff
LTE python bindings patch (158.20 KB, patch) 2018-08-21 08:35 UTC, Zoraze Ali	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Zoraze Ali 2018-08-21 08:29:52 UTC

I have noticed that the functions, "AssignUeIpv6Address" and "GetUeDefaultGatewayAddress6" are locally defined in EmuEpcHelper and PointToPointEpcHelper classes, rather than inheriting them from EpcHelper class.

Therefore, for the sake of consistency, these functions should be declared as pure virtual in EpcHelper class, and EmuEpcHelper and PointToPointEpcHelper classes can override them.

Kind regards,
Zoraze

Comment 1 Zoraze Ali 2018-08-21 08:32:18 UTC

Created attachment 3161 [details]
Patch

Comment 2 Zoraze Ali 2018-08-21 08:35:46 UTC

Created attachment 3162 [details]
LTE python bindings patch

This patch updates the LTE python bindings after applying the first patch.

Comment 3 Tom Henderson 2018-08-26 09:51:50 UTC

pushed in changeset 13753:af66aff96a95