Bugzilla – Bug 2979
Unused functions and overlapping variables in UE RRC and UE CCM
Last modified: 2018-09-05 10:29:18 UTC
Hi, I am working to resolve https://www.nsnam.org/bugzilla/0 and I noticed that there are following unused functions in lte-ue-rrc.h/cc and lte-ue-simple-ue-component-carrier-manager.h/cc, respectively. * DoComponentCarrierEnabling * DoNotifyConnectionReconfigurationMsg It seems these functions are the residue of an incomplete effort to remove/disable component carriers at runtime. Since this functionality is not implemented yet, I would suggest removing these functions from lte-ue-rrc.h/cc and simple-ue-component-carrier-manager.h/cc classes. And, keep their declaration in SAPs for any future reuse/extension. Following this change, the variable m_noOfComponentCarriersEnabled would be of no use, and can also be removed. We should use m_noOfComponentCarriers in place this variable in simple-ue-component-carrier-manager.cc. I am putting Alexander Krotov in Cc to get his feedback since he worked with CA during google summer of code. Kind regards, Zoraze
Here are my proposed changes: https://github.com/Zoraze/ns-3-dev-git/commit/a8eff48a848e26258c756503da4423ca26040dac
Pushed to changeset: 13780:a47bf2a2b44e