Bug 2979 - Unused functions and overlapping variables in UE RRC and UE CCM
Unused functions and overlapping variables in UE RRC and UE CCM
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: lte
ns-3-dev
All All
: P3 normal
Assigned To: Biljana Bojović
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-30 05:09 UTC by Zoraze Ali
Modified: 2018-09-05 10:29 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zoraze Ali 2018-08-30 05:09:25 UTC
Hi,

I am working to resolve https://www.nsnam.org/bugzilla/﷒0﷓ and I noticed that there are following unused functions in lte-ue-rrc.h/cc and lte-ue-simple-ue-component-carrier-manager.h/cc, respectively.

* DoComponentCarrierEnabling
* DoNotifyConnectionReconfigurationMsg

It seems these functions are the residue of an incomplete effort to remove/disable component carriers at runtime. Since this functionality is not implemented yet, I would suggest removing these functions from lte-ue-rrc.h/cc and simple-ue-component-carrier-manager.h/cc classes. And, keep their declaration in SAPs for any future reuse/extension.  

Following this change, the variable m_noOfComponentCarriersEnabled would be of no use, and can also be removed. We should use m_noOfComponentCarriers in place this variable in simple-ue-component-carrier-manager.cc. 

I am putting Alexander Krotov in Cc to get his feedback since he worked with CA during google summer of code.

Kind regards,
Zoraze
Comment 1 Zoraze Ali 2018-08-31 06:15:09 UTC
Here are my proposed changes: https://github.com/Zoraze/ns-3-dev-git/commit/a8eff48a848e26258c756503da4423ca26040dac
Comment 2 Zoraze Ali 2018-09-05 10:29:18 UTC
Pushed to changeset: 13780:a47bf2a2b44e