Bug 2995 – Add structs for the parameters of TxOpportunity and ReceivePdu

Bug 2995 - Add structs for the parameters of TxOpportunity and ReceivePdu


Summary:	Add structs for the parameters of TxOpportunity and ReceivePdu

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 enhancement
Assigned To:	Biljana Bojović

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-10-01 04:16 UTC by Zoraze Ali
Modified:	2018-10-02 09:11 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
enhancement patch (48.96 KB, patch) 2018-10-01 04:16 UTC, Zoraze Ali	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Zoraze Ali 2018-10-01 04:16:26 UTC

Created attachment 3189 [details]
enhancement patch

Hi,

This enhancement would introduce structs for the parameters of NotifyTxOpportunity and ReceivePdu methods in lte-mac-sap.h. This is the same logic as used for LteMacSapProvider::ReportBufferStatusParameters and LteMacSapProvider::TransmitPduParameters. 

It will make it possible to introduce more parameters easily without stuffing them individually into the NotifyTxOpportunity and ReceivePdu functions declarations.

The patch is created on top of the changeset 13809:cb31a3f56a28

Kind regards,
Zoraze

Comment 1 Biljana Bojović 2018-10-01 04:25:48 UTC

I agree, this enhancement will facilitate future addition of the parameters to these two functions, and will also allow easier manipulation with existing parameters.

Comment 2 Zoraze Ali 2018-10-02 09:11:31 UTC

Hi Biljana,

Thanks for reviewing it. 

Pushed in changeset 13814:637cc8ebb9fa

Kind regards,
Zoraze