Bug 3001 – MPI example may have an error in comment

Bug 3001 - MPI example may have an error in comment


Summary:	MPI example may have an error in comment

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	mpi
Version:	unspecified
Hardware:	PC Linux

Importance:	P5 normal
Assigned To:	Peter Barnes

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-10-22 23:06 UTC by Tom Henderson
Modified:	2018-11-05 15:17 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
patch to fix (804 bytes, patch) 2018-10-22 23:07 UTC, Tom Henderson	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2018-10-22 23:06:17 UTC

From ParthPratim's pull request here:

https://github.com/nsnam/ns-3-dev-git/pull/24

quoting:

The codes in line number 126 and 127 adds leaf nodes on the right (according to the explanation in the diagram in the top of the source code) with system id 1, defined in previous lines. But the comments written in line number 125 does not describe what the following lines actually do, as it states that leaf nodes were being added to the left which apparently were already been added in previous lines above. This commenting error could cause problems for new users with minimum to no understanding of ns-3 usage. Suitable changes have been made i.e. left was changed to right.

Comment 1 Tom Henderson 2018-10-22 23:07:59 UTC

Created attachment 3194 [details]
patch to fix

Comment 2 Peter Barnes 2018-11-05 15:17:52 UTC

Merged in r13838 (b21235f7)