Bugzilla – Bug 3003
Refactoring of WifiRemoteStationManager
Last modified: 2018-11-18 03:20:22 UTC
I am working on various refactoring patches for 11ad and 11ax integration to ns-3-dev. WifiRemoteStationManager has grown over the years and deserves a refactoring.
Created attachment 3200 [details] patch1: Reduce code size by removing what we can outside of the class
Created attachment 3201 [details] patch2: Move GetControlAnswerMode to MacLow GetControlAnswerMode is used by MacLow and this was causing a lot of issues when integrating 802.11ad code (and I guess 11ax in the future). Furthermore, this is the kind of method implemented in the firmware in practice, so MacLow is according to me the best place for selecting the mode of the response frame.
I have those two patches for the moment, let me know what you think about it and whether you still see some potential improvements.
(In reply to sebastien.deronne from comment #2) > Created attachment 3201 [details] > patch2: Move GetControlAnswerMode to MacLow Hello Sébastien. Quick comment: the UseGreenfieldForDestination method in Patch 2 seems to be already defined in Patch 1.
(In reply to Rediet from comment #4) > (In reply to sebastien.deronne from comment #2) > > Created attachment 3201 [details] > > patch2: Move GetControlAnswerMode to MacLow > > Hello Sébastien. > Quick comment: the UseGreenfieldForDestination method in Patch 2 seems to be > already defined in Patch 1. What do you mean? This method is already there.
I'd like to push this in the coming days.
(In reply to sebastien.deronne from comment #5) > (In reply to Rediet from comment #4) > > Hello Sébastien. > > Quick comment: the UseGreenfieldForDestination method in Patch 2 seems to be > > already defined in Patch 1. > > What do you mean? This method is already there. Sorry, my mistake, I didn't see that it was simply moved up in the .h.
Patches pushed in changesets 13858:63e7f6b8eeaf and 13859:8af38198d131, respectively.