Bug 3016 – Wrong argument for ResetBa in QosTxop::AddBaResponseTimeout

Bug 3016 - Wrong argument for ResetBa in QosTxop::AddBaResponseTimeout


Summary:	Wrong argument for ResetBa in QosTxop::AddBaResponseTimeout

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-11-19 09:06 UTC by Rediet
Modified:	2018-11-28 12:14 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Patch to apply (752 bytes, patch) 2018-11-19 09:06 UTC, Rediet	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rediet 2018-11-19 09:06:39 UTC

Created attachment 3223 [details]
Patch to apply

There is a small typo in QosTxop::AddBaResponseTimeout: when scheduling ResetBa, current header's information is used instead of recipient.
However, since AddBaResponseTimeout itself is scheduled, another packet can currently be handled upon expiry of the timeout. In our case, it was a broadcast frame which lead to a failed assert when calling ResetBa (non-existent agreement).
Attached is a simple patch correcting this.

Comment 1 Rediet 2018-11-28 12:14:13 UTC

Similar patch pushed by Sébastien in changeset 13868:80bf979d57c9