Bug 302 – CSMA Devices should default to DIX not LLC encapsulation.

Bug 302 - CSMA Devices should default to DIX not LLC encapsulation.


Summary:	CSMA Devices should default to DIX not LLC encapsulation.

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	devices
Version:	ns-3.1
Hardware:	All All

Importance:	P1 normal
Assigned To:	Craig Dowell

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-08-29 19:30 UTC by Craig Dowell
Modified:	2008-09-05 19:00 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Craig Dowell 2008-08-29 19:30:32 UTC

CSMA Devices should default to DIX not LLC encapsulation.

Comment 1 Tom Henderson 2008-08-30 17:11:50 UTC

I am not sure about this attribute:

  static const uint16_t DEFAULT_PAYLOAD_LENGTH = 1500;

    .AddAttribute ("PayloadLength",
                   "The max PHY-level payload length of packets sent over this device.",
                   UintegerValue (DEFAULT_PAYLOAD_LENGTH),


I think it may be clearer to either support an attribute called "FrameSize" and make it default to 1518, or else eliminate this attribute entirely and make the MTU setting govern everything.  As it is now, when moving the default encapsulation to DIX, this attribute and the default MTU will be the same.

(it may be that the simplest from a user perspective is to just support SetMTU and have the frame size be derived from the sum of the MTU plus layer-2 headers)

We should also plan about what we will do when we get to supporting VLANs.  It will require a new encapsulation type and probably some more API to control the tag setting.

Comment 2 Craig Dowell 2008-09-05 18:42:40 UTC

Preliminaries done.  Just need to flip the switch and regenerate reference traces.