Bugzilla – Bug 3021
Add trace source once an 802.11ax HE-SIG is received
Last modified: 2018-12-03 15:50:33 UTC
Created attachment 3230 [details] Proposal In the scope of 802.11ax ObssPd implementation, we need a callback once a HE-SIG is received. This trace source should (at least) provide the received RSSI and BSS color. I made a patch for this (based on Scott Carpenter's work). Note that we might have a specific HeWifiTxVector in the future to hold the BssColor, but for the moment we accepted to store this in the WifiTxVector.
Regarding this question: +}; //replace by passing PHY headers? I would vote for the way you have it (new structure). However, I think the documentation should be clarified that this is not actually calling the callback at the notional end of HE-SIG-A, but at the existing event at the end of preamble (after training fields). Also, there is a bit of ambiguity in that in some places, it refers to 'end of HE-SIG' (including HE-SIG-B?) and others at 'end of HE-SIG-A'. Perhaps documentation string should clarify that this is presently called at the end of preamble after both HE SIG fields have been received, as well as training fields.
(In reply to Tom Henderson from comment #1) > Regarding this question: > > +}; //replace by passing PHY headers? > > I would vote for the way you have it (new structure). > > However, I think the documentation should be clarified that this is not > actually calling the callback at the notional end of HE-SIG-A, but at the > existing event at the end of preamble (after training fields). Also, there > is a bit of ambiguity in that in some places, it refers to 'end of HE-SIG' > (including HE-SIG-B?) and others at 'end of HE-SIG-A'. Perhaps > documentation string should clarify that this is presently called at the end > of preamble after both HE SIG fields have been received, as well as training > fields. OK Tom, I agree. I will work on an updated patch.
Created attachment 3234 [details] patch with updated documentation I updated the documentation of the new trace source.
Pushed in changeset 13878:0cb5fc48c184