Bug 303 – DataCalculator::GetKey triggers a PyBindGen bug

Bug 303 - DataCalculator::GetKey triggers a PyBindGen bug


Summary:	DataCalculator::GetKey triggers a PyBindGen bug

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	general
Version:	pre-release
Hardware:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-08-31 17:29 UTC by Gustavo J. A. M. Carneiro
Modified:	2008-09-02 13:05 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2008-08-31 17:29:58 UTC

DataCalculator::GetKey triggers a PyBindGen bug because it uses 'const std::string' as return type.  Fixing that PyBindGen bug is more complicated than it seems and I decided to do some heavy refactoring which will take some time.

Since "const std::string" makes no sense at all anyway, do you mind changing to std::string?  This so that I can rescan API so that Python bindings to cover the stats module.


PS: the bugzilla comoponent list should have a "general" component, for when there is no matching component yet, as in this case.

Comment 1 Tom Henderson 2008-08-31 17:34:54 UTC

(In reply to comment #0)

> PS: the bugzilla comoponent list should have a "general" component, for when
> there is no matching component yet, as in this case.
> 

added

Comment 2 Gustavo J. A. M. Carneiro 2008-09-02 06:15:10 UTC

Nevermind, I fixed PyBindGen.

Comment 3 Mathieu Lacage 2008-09-02 11:57:10 UTC

no, it's a bug. It makes no sense to have return value types be const

Comment 4 Mathieu Lacage 2008-09-02 13:05:39 UTC

changeset 55dedf98ad49