Bug 326 – Always run regression tests with ./waf check

Bug 326 - Always run regression tests with ./waf check


Summary:	Always run regression tests with ./waf check

Status:	RESOLVED INVALID

Product:	ns-3
Classification:	Unclassified
Component:	build system
Version:	pre-release
Hardware:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-09-09 12:30 UTC by Mathieu Lacage
Modified:	2008-09-25 11:26 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Lacage 2008-09-09 12:30:54 UTC

instead, the regressions should be run from waf check

Comment 1 Rajib Bhattacharjea 2008-09-09 13:16:38 UTC

The regressions take quite a while to run, and what if I want JUST the unit tests and not the regressions, or vice versa?  Perhaps we could keep --regression, add a --unit-tests (which does what "check" does now), and have "check" simply run both unit tests and regressions.

Comment 2 Gustavo J. A. M. Carneiro 2008-09-10 09:57:03 UTC

(In reply to comment #0)
> instead, the regressions should be run from waf check

-1

Regression tests require network access, can take long to run, and are crude.  Besides, you can run both regression and unit tests with ./waf check --regression.

Comment 3 Tom Henderson 2008-09-11 17:10:17 UTC

I agree with previous comments against this suggestion.  I was just in a situation today where I wanted to run waf check but I had no network access.

Comment 4 Gustavo J. A. M. Carneiro 2008-09-25 06:35:54 UTC

Re-titling bug with a better description.  But I still don't like it.  I'm not sure why this is being proposed for ns 3.2.1...

Comment 5 Mathieu Lacage 2008-09-25 11:26:11 UTC

I am fine with closing this since it seems everyone agrees that the current behavior is desirable. 
marking INVALID.