Bug 352 – Wifi STA mac address problems

Bug 352 - Wifi STA mac address problems


Summary:	Wifi STA mac address problems

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	devices
Version:	ns-3.2
Hardware:	All All

Importance:	P3 normal
Assigned To:	Mathieu Lacage

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-09-17 13:33 UTC by Gustavo J. A. M. Carneiro
Modified:	2008-10-16 06:47 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch to fix it (1.10 KB, patch) 2008-09-17 13:34 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
foo (538 bytes, patch) 2008-10-16 06:27 UTC, Mathieu Lacage	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2008-09-17 13:33:28 UTC

In Wifi infrastructure more:
1. STA X sends a broadcast
2. AP Y retransmits the broadcast for all nodes to receive
3. STA X receives the retransmission and receives it

Step 3 is bad, the STA should not forward to the upper layers broadcasts that it has sent.

Comment 1 Gustavo J. A. M. Carneiro 2008-09-17 13:34:19 UTC

Created attachment 258 [details]
patch to fix it

Comment 2 Mathieu Lacage 2008-10-16 04:49:34 UTC

I would suggest to check for hdr->GetAddr3 () from the caller rather than from the callee. i.e., ForwardUp should not be doing the address check. Its caller should.

Comment 3 Gustavo J. A. M. Carneiro 2008-10-16 06:15:42 UTC

OK, but that would mean changing the signature of ForwardUp to include a new address argument.

Comment 4 Mathieu Lacage 2008-10-16 06:27:55 UTC

Created attachment 265 [details]
foo

please, test the attached.

Comment 5 Gustavo J. A. M. Carneiro 2008-10-16 06:45:27 UTC

Comment on attachment 265 [details]
foo

It fixes the bug.

Comment 6 Mathieu Lacage 2008-10-16 06:47:28 UTC

changeset d26d57ddf801