Bug 386 – nsc tcp socket

Bug 386 - nsc tcp socket


Summary:	nsc tcp socket

Status:	RESOLVED FIXED

Product:	nsc
Classification:	Unclassified
Component:	core
Version:	unspecified
Hardware:	All All

Importance:	P3 normal
Assigned To:	Sam Jansen

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-10-22 02:16 UTC by Mathieu Lacage
Modified:	2008-10-24 03:23 UTC (History)
CC List:	0 users

See Also:

Attachments
proposed patch (2.04 KB, patch) 2008-10-22 02:17 UTC, Mathieu Lacage	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Lacage 2008-10-22 02:16:22 UTC

While working on the ns-3-simu branch, I uncovered a couple of more or less serious bugs in the nsc tcp socket code:
1) you can't set m_errno from SendPendingData because it is not always called from user context
2) you must not use a packet after storing it in m_txBuffer and calling SendPendingData

Comment 1 Mathieu Lacage 2008-10-22 02:17:32 UTC

Created attachment 276 [details]
proposed patch

I did test this patch for quite a while so, I am reasonably confident about its stability.

Comment 2 Sam Jansen 2008-10-22 16:52:01 UTC

I admit to not knowing this code in detail. You probably understand what is going on much better than I, so I have no problems at all with you committing your patch. If you see Florian you could ask him about it perhaps, but if not then as far as I'm concerned its fine.

... I have briefly read the patch and it looks good as far as I can tell.

Comment 3 Mathieu Lacage 2008-10-24 03:23:03 UTC

changeset 317ccc4ebb4e