Bug 408 – No duplicate filtering for managament frames

Bug 408 - No duplicate filtering for managament frames


Summary:	No duplicate filtering for managament frames

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P1 major
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-11-13 09:05 UTC by Kirill V. Andreev
Modified:	2008-11-26 04:25 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Added duplicate filtering for non-data unicast frames (763 bytes, patch) 2008-11-13 09:05 UTC, Kirill V. Andreev	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kirill V. Andreev 2008-11-13 09:05:50 UTC

Created attachment 302 [details]
Added duplicate filtering for non-data unicast frames

Duplicate filtering is implemented in mac-rx-middle.cc only for data frames, but managament frames also need this procedure.

Comment 1 Mathieu Lacage 2008-11-25 09:09:17 UTC

Is there a specific reason why you simply did not move checks SequenceControlSmaller and IsDuplicate from the first clause of the if (IsData ()) statement to the beginning of the function MacRxMiddle::Receive ?

(sorry it took me so long to review this patch)

Comment 2 Kirill V. Andreev 2008-11-26 04:07:06 UTC

There is no reason. Of course, it would be better to make this check befor this if(). :)

Comment 3 Mathieu Lacage 2008-11-26 04:25:11 UTC

changeset f38616f83c3b