Bug 463 – allinone download.py should probably not download NSC to OS X

Bug 463 - allinone download.py should probably not download NSC to OS X


Summary:	allinone download.py should probably not download NSC to OS X

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	build system
Version:	ns-3-dev
Hardware:	Mac Intel Mac OS

Importance:	P5 normal
Assigned To:	Gustavo J. A. M. Carneiro

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-01-10 11:58 UTC by Tom Henderson
Modified:	2009-02-18 05:57 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
proposed patch (631 bytes, patch) 2009-01-13 09:40 UTC, Tom Henderson	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2009-01-10 11:58:44 UTC

#
    # Get NSC
    #
OS X HFS+ (case preserving, case insensitive) seems to have issue with the NSC code, when I run download.py


Required NSC version:  nsc-0.5.0
Retrieving nsc from https://secure.wand.net.nz/mercurial/nsc
 =>  hg clone https://secure.wand.net.nz/mercurial/nsc nsc
requesting all changes
adding changesets
adding manifests
adding file changes
added 270 changesets with 17375 changes to 14991 files
abort: case-folding collision between linux-2.6.26/include/linux/netfilter/xt_tcpmss.h and linux-2.6.26/include/linux/netfilter/xt_TCPMSS.h
Traceback (most recent call last):
  File "./download.py", line 184, in <module>
    sys.exit(main())
  File "./download.py", line 179, in main
    get_nsc(ns3_dir)
  File "./download.py", line 162, in get_nsc
    nsc_clone()
  File "./download.py", line 140, in nsc_clone
    run_command(['hg', 'clone', constants.NSC_REPO, constants.LOCAL_NSC_PATH])
  File "/scratch/hg/gjc/ns-3-allinone/util.py", line 24, in run_command
    raise CommandError("Command %r exited with code %i" % (argv, retval))
util.CommandError: Command ['hg', 'clone', 'https://secure.wand.net.nz/mercurial/nsc', 'nsc'] exited with code 255
 
probably we should suppress the download of NSC on OS X and print out a notification to the user that it was skipped due to compatibility issues

Comment 1 Tom Henderson 2009-01-13 09:40:27 UTC

Created attachment 350 [details]
proposed patch

Comment 2 Gustavo J. A. M. Carneiro 2009-01-24 10:53:09 UTC

Comment on attachment 350 [details]
proposed patch

Looks good.  Although I usually use sys.platform == 'darwin'; it's simpler.

Comment 3 Gustavo J. A. M. Carneiro 2009-02-18 05:57:14 UTC

Committed slightly modified patch.