Bug 485 – implement deserialization of normal/gaussian random variables

Bug 485 - implement deserialization of normal/gaussian random variables


Summary:	implement deserialization of normal/gaussian random variables

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	core
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	Michele Weigle

URL:
Keywords:	patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-02-02 11:54 UTC by Gustavo J. A. M. Carneiro
Modified:	2009-03-03 06:25 UTC (History)
CC List:	4 users (show)

See Also:

Attachments
patch (1.84 KB, patch) 2009-02-02 11:54 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
implement serialization also (5.79 KB, patch) 2009-02-25 06:22 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
rebased patch (3.91 KB, patch) 2009-02-25 07:46 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2009-02-02 11:54:03 UTC

Created attachment 366 [details]
patch

like the summary says

Comment 1 Mathieu Lacage 2009-02-25 05:25:48 UTC

The patch looks good to me but, gustavo, could you please add serialization support also ?

Comment 2 Gustavo J. A. M. Carneiro 2009-02-25 06:22:05 UTC

Created attachment 388 [details]
implement serialization also

Comment 3 Mathieu Lacage 2009-02-25 06:26:02 UTC

(In reply to comment #2)
> Created an attachment (id=388) [details]
> implement serialization also
> 

Would you mind generate a final patch against the tip of ns-3-dev ? This patch does not apply since the rng changes have been merged.

Comment 4 Gustavo J. A. M. Carneiro 2009-02-25 07:46:13 UTC

Created attachment 391 [details]
rebased patch

Comment 5 Mathieu Lacage 2009-02-25 07:56:20 UTC

ok for me. let's ask raj and michele for an ack.

Comment 6 Michele Weigle 2009-03-02 15:41:03 UTC

I don't see any problems with this patch.  Is this something that should be go ahead and be added for 3.4 or wait until later?

Comment 7 Rajib Bhattacharjea 2009-03-02 15:51:42 UTC

(In reply to comment #5)
> ok for me. let's ask raj and michele for an ack.
> 

ACK.

(In reply to comment #6)
> I don't see any problems with this patch.  Is this something that should be go
> ahead and be added for 3.4 or wait until later?
> 

My two cents is that there is no sense in allowing this to bitrot again if it works as promised now.

Comment 8 Gustavo J. A. M. Carneiro 2009-03-03 06:25:00 UTC

I'll take that as approval.  Committed.