Bug 515 – Compile python bindings with -fvisibility=hidden

Bug 515 - Compile python bindings with -fvisibility=hidden


Summary:	Compile python bindings with -fvisibility=hidden

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	python bindings
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	Gustavo J. A. M. Carneiro

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-03-01 13:01 UTC by Gustavo J. A. M. Carneiro
Modified:	2009-03-12 15:51 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
the patch (896 bytes, patch) 2009-03-01 13:01 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
also checks for gcc version >= 4.0.0 (972 bytes, patch) 2009-03-03 10:24 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2009-03-01 13:01:20 UTC

Created attachment 394 [details]
the patch

Like the summary says.  Following up on the advice in this page:

http://gcc.gnu.org/wiki/Visibility

Makes python bindings smaller and faster to load.

Tested on Ubuntu 8.10 and darwin-ppc regression host.

I think I need the release manager's approval to commit this, right?  I think it should be safe to apply.

Patch attached.

Comment 1 Gustavo J. A. M. Carneiro 2009-03-03 10:24:23 UTC

Created attachment 395 [details]
also checks for gcc version >= 4.0.0

Comment 2 Rajib Bhattacharjea 2009-03-12 15:51:28 UTC

4253:732b877beb23
4255:07f1fdd8a33e