Bug 690 – tcp-nsc-lfn.cc is broken beyond repair

Bug 690 - tcp-nsc-lfn.cc is broken beyond repair


Summary:	tcp-nsc-lfn.cc is broken beyond repair

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	samples
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-09-28 04:38 UTC by Mathieu Lacage
Modified:	2010-01-16 17:02 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
remove cwnd tracing code (1.05 KB, patch) 2010-01-13 00:19 UTC, Tom Henderson	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Lacage 2009-09-28 04:38:05 UTC

this code appears to assume that the m_cwnd variable defined in NscTcpSocketImpl is actually a meaningful variable. 

It is not. I can't believe how broken this is. We should remove _at least_ the tracing part from that example file.

Comment 1 Tom Henderson 2010-01-13 00:18:54 UTC

(In reply to comment #0)
> this code appears to assume that the m_cwnd variable defined in
> NscTcpSocketImpl is actually a meaningful variable. 
> 
> It is not. I can't believe how broken this is. We should remove _at least_ the
> tracing part from that example file.

the attached patch removes that part of the example, without changing program behavior.

A bigger issue (not fixed for the moment) is to write a test suite that exercises/tests the socket and attribute API when NSC is used.

Comment 2 Tom Henderson 2010-01-13 00:19:24 UTC

Created attachment 720 [details]
remove cwnd tracing code

Comment 3 Tom Henderson 2010-01-16 17:02:05 UTC

changeset c64c692147f6