Bug 786 – Make Ipv4Address hashable from Python

Bug 786 - Make Ipv4Address hashable from Python


Summary:	Make Ipv4Address hashable from Python

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	python bindings
Version:	ns-3-dev
Hardware:	All All

Importance:	P2 enhancement
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-01-07 08:20 UTC by Gustavo J. A. M. Carneiro
Modified:	2010-01-14 06:45 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch (1.38 KB, patch) 2010-01-07 08:20 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2010-01-07 08:20:08 UTC

Created attachment 711 [details]
patch

Like the summary says.  Need to add tp_hash function to the type wrapper.

Comment 1 Faker Moatamri 2010-01-07 10:48:13 UTC

commit once the code freeze finishes, on january 20th...
thanks

Comment 2 Faker Moatamri 2010-01-13 07:19:28 UTC

You can commit now if all tests and regression tests pass.

Comment 3 Gustavo J. A. M. Carneiro 2010-01-14 06:20:41 UTC

(In reply to comment #2)
> You can commit now if all tests and regression tests pass.

Does this mean the ns-3-dev tree is again open for development, or only bug fixes?  NS-3.7 is already on a separate branch?

Comment 4 Faker Moatamri 2010-01-14 06:39:05 UTC

No ns 3.7 is not on a different branch, but the maintainer of each module can decide if he wants to upload bug fix to the ns-3 dev (which will be ns-3.7). It is not open for development but only for P1 bug fixes, and the maintainers of a module are the ones who will decide to upload a patch for a bug or not.

If you think that this bug fix is important and you want it to be in the ns-3.7 release, please upload the fix. We reserve the right to revert the patch if it breaks builds/tests.

Comment 5 Gustavo J. A. M. Carneiro 2010-01-14 06:45:53 UTC

Since it's a low-impact small patch, I commit it.