Bugzilla – Bug 922
Inconsistent declaration of class/struct in wifi-remote-station-manager.h
Last modified: 2010-06-07 20:46:28 UTC
Created attachment 889 [details] Proposed patch. Inconsistent declaration of the following as class/struct triggering static analysis warnings. No actual functional deficiencies. debug/ns3/wifi-remote-station-manager.h:438:1: error: struct 'WifiRemoteStationState' was previously declared as a class [-Wmismatched-tags] struct WifiRemoteStationState ^~~~~~ class debug/ns3/wifi-remote-station-manager.h:35:7: note: previous use is here class WifiRemoteStationState; ^ debug/ns3/wifi-remote-station-manager.h:461:1: error: struct 'WifiRemoteStation' was previously declared as a class [-Wmismatched-tags] struct WifiRemoteStation ^~~~~~ class debug/ns3/wifi-remote-station-manager.h:34:7: note: previous use is here class WifiRemoteStation; debug/ns3/wifi-remote-station-manager.h:463:3: error: struct 'WifiRemoteStationState' was previously declared as a class [-Wmismatched-tags] struct WifiRemoteStationState *m_state; ^~~~~~ class debug/ns3/wifi-remote-station-manager.h:35:7: note: previous use is here class WifiRemoteStationState
Created attachment 890 [details] Proposed patch. Sorry, last proposed patch was bad.
changeset: 6339:84cbcc1a3f16 the changes that I implemented are slightly different than yours, please let me know if they are ok for you or you still have some problems.
Thanks. Happy with the change (I forgot C++ doesn't need the keyword struct/class except for the class/struct definition).