Bug 922 - Inconsistent declaration of class/struct in wifi-remote-station-manager.h
Inconsistent declaration of class/struct in wifi-remote-station-manager.h
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: wifi
ns-3-dev
All All
: P5 trivial
Assigned To: Nicola Baldo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-27 20:16 UTC by Quincy Tse
Modified: 2010-06-07 20:46 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch. (693 bytes, patch)
2010-05-27 20:16 UTC, Quincy Tse
Details | Diff
Proposed patch. (6.97 KB, patch)
2010-05-27 21:14 UTC, Quincy Tse
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Quincy Tse 2010-05-27 20:16:02 UTC
Created attachment 889 [details]
Proposed patch.

Inconsistent declaration of the following as class/struct triggering static analysis warnings. No actual functional deficiencies.

debug/ns3/wifi-remote-station-manager.h:438:1: error: struct
      'WifiRemoteStationState' was previously declared as a class
      [-Wmismatched-tags]
struct WifiRemoteStationState
^~~~~~
class
debug/ns3/wifi-remote-station-manager.h:35:7: note: previous use is here
class WifiRemoteStationState;
      ^
debug/ns3/wifi-remote-station-manager.h:461:1: error: struct
      'WifiRemoteStation' was previously declared as a class
      [-Wmismatched-tags]
struct WifiRemoteStation
^~~~~~
class
debug/ns3/wifi-remote-station-manager.h:34:7: note: previous use is here
class WifiRemoteStation;

debug/ns3/wifi-remote-station-manager.h:463:3: error: struct
      'WifiRemoteStationState' was previously declared as a class
      [-Wmismatched-tags]
  struct WifiRemoteStationState *m_state;
  ^~~~~~
  class
debug/ns3/wifi-remote-station-manager.h:35:7: note: previous use is here
class WifiRemoteStationState
Comment 1 Quincy Tse 2010-05-27 21:14:09 UTC
Created attachment 890 [details]
Proposed patch.

Sorry, last proposed patch was bad.
Comment 2 Nicola Baldo 2010-06-07 10:34:17 UTC
changeset:   6339:84cbcc1a3f16

the changes that I implemented are slightly different than yours, please let me know if they are ok for you or you still have some problems.
Comment 3 Quincy Tse 2010-06-07 20:46:28 UTC
Thanks. Happy with the change (I forgot C++ doesn't need the keyword struct/class except for the class/struct definition).