Bug 485

Summary:	implement deserialization of normal/gaussian random variables
Product:	ns-3	Reporter:	Gustavo J. A. M. Carneiro <gjcarneiro>
Component:	core	Assignee:	Michele Weigle <mweigle>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mathieu.lacage, ns-bugs, raj.b, tomh
Priority:	P5	Keywords:	patch
Version:	ns-3-dev
Hardware:	All
OS:	All
Attachments:	patch implement serialization also rebased patch

Description Gustavo J. A. M. Carneiro 2009-02-02 11:54:03 UTC

Created attachment 366 [details]
patch

like the summary says

Comment 1 Mathieu Lacage 2009-02-25 05:25:48 UTC

The patch looks good to me but, gustavo, could you please add serialization support also ?

Comment 2 Gustavo J. A. M. Carneiro 2009-02-25 06:22:05 UTC

Created attachment 388 [details]
implement serialization also

Comment 3 Mathieu Lacage 2009-02-25 06:26:02 UTC

(In reply to comment #2)
> Created an attachment (id=388) [details]
> implement serialization also
> 

Would you mind generate a final patch against the tip of ns-3-dev ? This patch does not apply since the rng changes have been merged.

Comment 4 Gustavo J. A. M. Carneiro 2009-02-25 07:46:13 UTC

Created attachment 391 [details]
rebased patch

Comment 5 Mathieu Lacage 2009-02-25 07:56:20 UTC

ok for me. let's ask raj and michele for an ack.

Comment 6 Michele Weigle 2009-03-02 15:41:03 UTC

I don't see any problems with this patch.  Is this something that should be go ahead and be added for 3.4 or wait until later?

Comment 7 Rajib Bhattacharjea 2009-03-02 15:51:42 UTC

(In reply to comment #5)
> ok for me. let's ask raj and michele for an ack.
> 

ACK.

(In reply to comment #6)
> I don't see any problems with this patch.  Is this something that should be go
> ahead and be added for 3.4 or wait until later?
> 

My two cents is that there is no sense in allowing this to bitrot again if it works as promised now.

Comment 8 Gustavo J. A. M. Carneiro 2009-03-03 06:25:00 UTC

I'll take that as approval.  Committed.