Bug 923

Summary: Inconsistent declaration of class/struct in mac-low.h
Product: ns-3 Reporter: Quincy Tse <quincy.tse>
Component: wifiAssignee: Nicola Baldo <nicola>
Status: RESOLVED FIXED    
Severity: trivial CC: ns-bugs
Priority: P5    
Version: ns-3-dev   
Hardware: All   
OS: All   
Attachments: Proposed patch.

Description Quincy Tse 2010-05-27 21:34:29 UTC
Created attachment 891 [details]
Proposed patch.

Created an attachment (id=889)
Proposed patch.

Inconsistent declaration of the following as class/struct triggering static analysis warnings. No actual functional deficiencies.

../src/devices/wifi/mac-low.cc:1404:3: error: struct 'SnrTag' was previously
      declared as a class [-Wmismatched-tags]
  struct SnrTag tag;
  ^~~~~~
  class
../src/devices/wifi/mac-low.cc:45:7: note: previous use is here
class SnrTag : public Tag
      ^
../src/devices/wifi/mac-low.cc:1483:3: error: struct 'SnrTag' was previously
      declared as a class [-Wmismatched-tags]
  struct SnrTag tag;
  ^~~~~~
  class
../src/devices/wifi/mac-low.cc:45:7: note: previous use is here
class SnrTag : public Tag
      ^
Comment 1 Nicola Baldo 2010-06-03 05:08:58 UTC
(In reply to comment #0)
> Inconsistent declaration of the following as class/struct triggering static
> analysis warnings. No actual functional deficiencies.
> 

I agree with this change. Please push to ns-3-dev if you have commit privileges, or let me know otherwise and I'll do it.

Nicola
Comment 2 Nicola Baldo 2010-06-07 10:34:45 UTC
changeset 6341:375d70f07323