Bug 923 – Inconsistent declaration of class/struct in mac-low.h

Bug 923 - Inconsistent declaration of class/struct in mac-low.h


Summary:	Inconsistent declaration of class/struct in mac-low.h

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 trivial
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-05-27 21:34 UTC by Quincy Tse
Modified:	2010-06-07 10:34 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Proposed patch. (514 bytes, patch) 2010-05-27 21:34 UTC, Quincy Tse	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Quincy Tse 2010-05-27 21:34:29 UTC

Created attachment 891 [details]
Proposed patch.

Created an attachment (id=889)
Proposed patch.

Inconsistent declaration of the following as class/struct triggering static analysis warnings. No actual functional deficiencies.

../src/devices/wifi/mac-low.cc:1404:3: error: struct 'SnrTag' was previously
      declared as a class [-Wmismatched-tags]
  struct SnrTag tag;
  ^~~~~~
  class
../src/devices/wifi/mac-low.cc:45:7: note: previous use is here
class SnrTag : public Tag
      ^
../src/devices/wifi/mac-low.cc:1483:3: error: struct 'SnrTag' was previously
      declared as a class [-Wmismatched-tags]
  struct SnrTag tag;
  ^~~~~~
  class
../src/devices/wifi/mac-low.cc:45:7: note: previous use is here
class SnrTag : public Tag
      ^

Comment 1 Nicola Baldo 2010-06-03 05:08:58 UTC

(In reply to comment #0)
> Inconsistent declaration of the following as class/struct triggering static
> analysis warnings. No actual functional deficiencies.
> 

I agree with this change. Please push to ns-3-dev if you have commit privileges, or let me know otherwise and I'll do it.

Nicola

Comment 2 Nicola Baldo 2010-06-07 10:34:45 UTC

changeset 6341:375d70f07323