|
Bugzilla – Full Text Bug Listing |
| Summary: | PointToPointNetDevice says promisc support is not implemented but it is. | ||
|---|---|---|---|
| Product: | ns-3 | Reporter: | Mathieu Lacage <mathieu.lacage> |
| Component: | devices | Assignee: | Craig Dowell <craigdo> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | craigdo, jpelkey, ns-bugs, tomh |
| Priority: | P5 | ||
| Version: | pre-release | ||
| Hardware: | All | ||
| OS: | All | ||
This FATAL_ERROR seems to be incorrect to me; probably a left over statement from the tracing rework a few cycles back. (In reply to comment #1) > This FATAL_ERROR seems to be incorrect to me; probably a left over statement > from the tracing rework a few cycles back. Should I just go ahead and commit this easy one? It makes sense to me to remove the fatal error as well. removed in changeset f75f34bce41d |
The NS_FATAL_ERROR below is less than helpful: void PointToPointNetDevice::SetPromiscReceiveCallback (NetDevice::PromiscReceiveCallback cb) { NS_FATAL_ERROR ("PointToPointNetDevice::SetPromiscReceiveCallback(): Not implemented"); m_promiscCallback = cb; } Would it be ok to commit a patch which removes this un-needed warning ?