Bug 950 – PointToPointNetDevice says promisc support is not implemented but it is.

Bug 950 - PointToPointNetDevice says promisc support is not implemented but it is.


Summary:	PointToPointNetDevice says promisc support is not implemented but it is.

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	devices
Version:	pre-release
Hardware:	All All

Importance:	P5 normal
Assigned To:	Craig Dowell

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-06-23 02:28 UTC by Mathieu Lacage
Modified:	2010-08-08 23:38 UTC (History)
CC List:	4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Lacage 2010-06-23 02:28:05 UTC

The NS_FATAL_ERROR below is less than helpful:
void
PointToPointNetDevice::SetPromiscReceiveCallback (NetDevice::PromiscReceiveCallback cb)
{
  NS_FATAL_ERROR ("PointToPointNetDevice::SetPromiscReceiveCallback(): Not implemented");
  m_promiscCallback = cb;
}


Would it be ok to commit a patch which removes this un-needed warning ?

Comment 1 Tom Henderson 2010-06-23 09:25:39 UTC

This FATAL_ERROR seems to be incorrect to me; probably a left over statement from the tracing rework a few cycles back.

Comment 2 Josh Pelkey 2010-08-04 14:17:46 UTC

(In reply to comment #1)
> This FATAL_ERROR seems to be incorrect to me; probably a left over statement
> from the tracing rework a few cycles back.

Should I just go ahead and commit this easy one?  It makes sense to me to remove the fatal error as well.

Comment 3 Craig Dowell 2010-08-08 22:27:15 UTC

removed in changeset f75f34bce41d