Bugzilla – Bug 852
Add support for 802.11g devices
Last modified: 2015-01-14 18:22:24 UTC
ns-3 currently lacks support for modelling of 802.11g devices - devices which may choose from the payload data rates and modulations described in IEEE 802.11-2007 Clauses 15, 18, and 19. This bug constitutes a feature request for the addition of the support necessary to model such devices. A partial patch for 802.11g support was previously posted to the ns-developers list: http://mailman.isi.edu/pipermail/ns-developers/2010-January/007290.html While this patch lay the groundwork for 802.11g support, it did not make necessary changes to the classes derived from WifiMac, the interference helper, and the yans error rate model.
I've uploaded to codereview a proposed change to address this feature request. Please comment: http://codereview.appspot.com/862041
Thank you for your effort in addressing this issue and considering previous contributions. I've commented your patch on codereview. Note that bug 871 could probably affect this patch as well.
I'm marking Bug 871 and Bug 881 as blockers of this one, because the changes required here are likely to be much cleaner if satisfactory solutions to those have already been implemented. There is code proposed for each of those bugs, so if you're worrying about this one then review attention on the proposed code for the blockers (or argument that they're not useful) is probably the way to go.
(In reply to comment #3) > I'm marking Bug 871 and Bug 881 as blockers of this one, because the changes > required here are likely to be much cleaner if satisfactory solutions to those > have already been implemented. You say that bug 881 is a blocker because it will introduce the Extended Supported Rates element, right?
(In reply to comment #4) > You say that bug 881 is a blocker because it will introduce the Extended > Supported Rates element, right? I wasn't clear, but no; I was suggesting that after a fix for bug 881, the Extended Supported Rates element could be more readily introduced as part of a fix for this bug. I'm convinced that addition of the Extended Supported Rates element does not fall in the scope of bug 881, but if you prefer then I could raise a new bug to also keep it distinct from this one.
So given that ns-3.9 is out, with fixes for bug 871 and bug 881 which were notionally blocking this one, I'd quite like to move this along. I've provided an updated proposed patch at Codereview Issue 862041, and pushed the equivalent changes into http://code.nsnam.org/deanarm/ns-3-dev-80211g I'd very much appreciate review and/or comment from anyone who is interested.
Hi Dean, I went carefully through your code on codereview. Very good work, you have my +1 to push it to ns-3-dev. Still, since the mesh code is affected, I think it is necessary for Kirill to approve the code as well. Thank you very much for your effort! Nicola
Hi! Patch for mesh is ok +1 from me
(In reply to comment #8) > Patch for mesh is ok > +1 from me Thanks, Nicola, Kirill. I've pushed the changes as 6596:6c562767d7b5 and 6597:7fbc895f7361 on ns-3-dev.